컨트롤러 레이어 리팩토링 #55
Merged
컨트롤러 레이어 리팩토링 #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- questionType, Field, Act를 기반으로 Question Service 관련 빈을 반환 - 이를 통해 중복 URL API 감소 - MultipleChoiceQuestionGradeService에 적용(questionType : multiple, questionField: license,major, act:grade)
- 본문 업데이트, 개시 허용, 해설 업데이트 API 축소
- 기존 공통된 Question Update관련 로직 테스트를 구현
- 도메인 단위 구별-> 레이어별 구별 에서 레이어별 구별 -> 도메인 단위 구별로 수정
- 호출부에선 Question으로 호출하여 재사용 극대화 - QuestionClassifyCategoryService에서 인자로 와일드카드를 받고 Question 명시적 반환
- URL 수정
- HTML 태그는 클래스단위로 관리 - 재사용 가능한 함수 분리
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
연관된 이슈
https://watermelon-clap.atlassian.net/jira/software/projects/CS/boards/3?selectedIssue=CS-92
작업 내용