Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KST24 coherent Galactic magnetic field model #513

Merged
merged 7 commits into from
Mar 14, 2025
Merged

Add KST24 coherent Galactic magnetic field model #513

merged 7 commits into from
Mar 14, 2025

Conversation

alexkorochkin
Copy link
Contributor

The PR adds KST24 coherent Galactic magnetic field to the CRPropa. Two files added, KST24Field.cpp and KST24Field.h, new class defined KST24Field.

@lukasmerten
Copy link
Member

Hi @alexkorochkin
So far it looks good to me, but I will need a bit more time to give it a more thorough look.

  • Please also edit the CHANGELOG file to reflect the new implementation.

@lukasmerten lukasmerten merged commit f9029de into CRPropa:master Mar 14, 2025
3 of 4 checks passed
@lukasmerten
Copy link
Member

Hi @alexkorochkin
I just merged your PR and added the changes in the CHANGELOG myself. Thanks again for providing your Galactic magnetic field model.

@alexkorochkin
Copy link
Contributor Author

Hi @lukasmerten
Great! Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasmerten lukasmerten lukasmerten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexkorochkin @lukasmerten