fix: remove unicode pi symbols in rotation extension #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #743 +/- ##
==========================================
+ Coverage 82.62% 82.67% +0.05%
==========================================
Files 62 62
Lines 7234 7234
Branches 6978 6978
==========================================
+ Hits 5977 5981 +4
+ Misses 883 880 -3
+ Partials 374 373 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cqc-alec
approved these changes
Jan 9, 2025
This was referenced Jan 9, 2025
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 10, 2025
## 🤖 New release * `tket2`: 0.7.0 -> 0.7.1 (✓ API compatible changes) * `tket2-hseries`: 0.7.1 -> 0.8.0 (⚠️ API breaking changes) ###⚠️ `tket2-hseries` breaking changes ``` --- failure enum_no_repr_variant_discriminant_changed: enum variant had its discriminant change value --- Description: The enum's variant had its discriminant value change. This breaks downstream code that used its value via a numeric cast like `as isize`. ref: https://doc.rust-lang.org/reference/items/enumerations.html#assigning-discriminant-values impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/enum_no_repr_variant_discriminant_changed.ron Failed in: variant QSystemOp::Rz 2 -> 3 in /tmp/.tmp2ye8Ro/tket2/tket2-hseries/src/extension/qsystem.rs:88 variant QSystemOp::PhasedX 3 -> 4 in /tmp/.tmp2ye8Ro/tket2/tket2-hseries/src/extension/qsystem.rs:89 variant QSystemOp::ZZMax 4 -> 5 in /tmp/.tmp2ye8Ro/tket2/tket2-hseries/src/extension/qsystem.rs:90 variant QSystemOp::ZZPhase 5 -> 6 in /tmp/.tmp2ye8Ro/tket2/tket2-hseries/src/extension/qsystem.rs:91 variant QSystemOp::TryQAlloc 6 -> 7 in /tmp/.tmp2ye8Ro/tket2/tket2-hseries/src/extension/qsystem.rs:92 variant QSystemOp::QFree 7 -> 8 in /tmp/.tmp2ye8Ro/tket2/tket2-hseries/src/extension/qsystem.rs:93 variant QSystemOp::Reset 8 -> 9 in /tmp/.tmp2ye8Ro/tket2/tket2-hseries/src/extension/qsystem.rs:94 variant QSystemOp::MeasureReset 9 -> 10 in /tmp/.tmp2ye8Ro/tket2/tket2-hseries/src/extension/qsystem.rs:95 ``` <details><summary><i><b>Changelog</b></i></summary><p> ## `tket2` <blockquote> ## [0.7.1](tket2-v0.7.0...tket2-v0.7.1) - 2025-01-10 ### Bug Fixes - remove unicode pi symbols in rotation extension (#743) </blockquote> ## `tket2-hseries` <blockquote> ## [0.8.0](tket2-hseries-v0.7.1...tket2-hseries-v0.8.0) - 2025-01-10 ### New Features - *(tket2-hseries)* [**breaking**] Redefine `QSystemOp::LazyMeasure` and introduce `QSystemOp::LazyMeasureReset` (#741) - *(tket2-hseries)* Lazify more flavours of measure ops (#742) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/).
|
What was the reason for this change? |
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.