Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add monomorphization and constant folding to QSystemPass #730

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

doug-q
Copy link
Contributor

@doug-q doug-q commented Dec 17, 2024

Closes #729

Note that constant folding is disabled by default as it currently does not work on modules.

@doug-q doug-q requested a review from a team as a code owner December 17, 2024 14:22
@doug-q doug-q requested a review from aborgna-q December 17, 2024 14:22
Closes #729

Note that constant folding is disabled by default as it currently does
not work on modules.

BREAKING CHANGE: `QSystemPass` now operates on a `&mut Hugr` rather than
a `impl HugrMut`.
@doug-q doug-q force-pushed the doug/monomorphisation-constant-folding branch from cf25210 to 53c045e Compare December 17, 2024 14:23
@ss2165 ss2165 requested review from ss2165 and removed request for aborgna-q December 17, 2024 14:25
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 56.25000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 82.68%. Comparing base (95090a2) to head (0542033).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tket2-hseries/src/lib.rs 56.25% 13 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #730      +/-   ##
==========================================
- Coverage   82.80%   82.68%   -0.12%     
==========================================
  Files          62       62              
  Lines        7200     7231      +31     
  Branches     6944     6975      +31     
==========================================
+ Hits         5962     5979      +17     
- Misses        867      880      +13     
- Partials      371      372       +1     
Flag Coverage Δ
python 82.42% <ø> (ø)
rust 82.69% <56.25%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tket2-hseries/src/lib.rs Outdated Show resolved Hide resolved
tket2-hseries/src/lib.rs Outdated Show resolved Hide resolved
@doug-q doug-q added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit aafd73c Dec 17, 2024
16 of 17 checks passed
@doug-q doug-q deleted the doug/monomorphisation-constant-folding branch December 17, 2024 16:15
@hugrbot hugrbot mentioned this pull request Dec 17, 2024
github-merge-queue bot pushed a commit that referenced this pull request Dec 18, 2024
## 🤖 New release
* `tket2`: 0.7.0 -> 0.7.1 (✓ API compatible changes)
* `tket2-hseries`: 0.7.0 -> 0.7.1 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

## `tket2`
<blockquote>

##
[0.7.0](tket2-v0.6.0...tket2-v0.7.0)
- 2024-12-16

### ⚠ BREAKING CHANGES

- Removed `load_guppy_*` methods. Use `Circuit::load_function_reader`
instead.
- Extension definitions and registries now use `Arc`s for sharing

### New Features

- [**breaking**] Track circuit extensions and read/write packages (#680)
- [**breaking**] update measurement and alloc operations (#702)

### Refactor

- [**breaking**] update to hugr 0.14 (#700)
</blockquote>

## `tket2-hseries`
<blockquote>

##
[0.7.1](tket2-hseries-v0.7.0...tket2-hseries-v0.7.1)
- 2024-12-18

### New Features

- Add monomorphization and constant folding to QSystemPass (#730)
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

---------

Co-authored-by: Agustín Borgna <[email protected]>
@hugrbot hugrbot mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add monomorphization and constant folding to tket2-hseries
2 participants