-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add monomorphization and constant folding to QSystemPass #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #729 Note that constant folding is disabled by default as it currently does not work on modules. BREAKING CHANGE: `QSystemPass` now operates on a `&mut Hugr` rather than a `impl HugrMut`.
doug-q
force-pushed
the
doug/monomorphisation-constant-folding
branch
from
December 17, 2024 14:23
cf25210
to
53c045e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #730 +/- ##
==========================================
- Coverage 82.80% 82.68% -0.12%
==========================================
Files 62 62
Lines 7200 7231 +31
Branches 6944 6975 +31
==========================================
+ Hits 5962 5979 +17
- Misses 867 880 +13
- Partials 371 372 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ss2165
reviewed
Dec 17, 2024
Co-authored-by: Seyon Sivarajah <[email protected]>
ss2165
approved these changes
Dec 17, 2024
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
## 🤖 New release * `tket2`: 0.7.0 -> 0.7.1 (✓ API compatible changes) * `tket2-hseries`: 0.7.0 -> 0.7.1 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> ## `tket2` <blockquote> ## [0.7.0](tket2-v0.6.0...tket2-v0.7.0) - 2024-12-16 ### ⚠ BREAKING CHANGES - Removed `load_guppy_*` methods. Use `Circuit::load_function_reader` instead. - Extension definitions and registries now use `Arc`s for sharing ### New Features - [**breaking**] Track circuit extensions and read/write packages (#680) - [**breaking**] update measurement and alloc operations (#702) ### Refactor - [**breaking**] update to hugr 0.14 (#700) </blockquote> ## `tket2-hseries` <blockquote> ## [0.7.1](tket2-hseries-v0.7.0...tket2-hseries-v0.7.1) - 2024-12-18 ### New Features - Add monomorphization and constant folding to QSystemPass (#730) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). --------- Co-authored-by: Agustín Borgna <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #729
Note that constant folding is disabled by default as it currently does not work on modules.