Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue: Python bindings UX #204

Closed
10 of 15 tasks
aborgna-q opened this issue Oct 27, 2023 · 1 comment
Closed
10 of 15 tasks

Tracking issue: Python bindings UX #204

aborgna-q opened this issue Oct 27, 2023 · 1 comment
Labels
python Pull requests that update Python code tracking-issue An issue tracking progress on multiple sub-tasks.

Comments

@aborgna-q
Copy link
Collaborator

aborgna-q commented Oct 27, 2023 •
edited
Loading

This is a tracking issue for improvements to the python API.

Documentation & repo structure

Issues

More bindings

DAG queries

Matching and rewriting

  • Expose rewrite primitives (SimpleRewrite, Inline*)
  • Rewrite combinators / rewrite strategies.
  • TASOBadger as a CustomPass. feat: TasoPass #185

Construction
@aborgna-q aborgna-q added py-bindings Python bindings tracking-issue An issue tracking progress on multiple sub-tasks. labels Oct 27, 2023
@aborgna-q aborgna-q mentioned this issue Oct 27, 2023
Closed
@aborgna-q aborgna-q pinned this issue Nov 8, 2023
@aborgna-q aborgna-q mentioned this issue Nov 10, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 10, 2023
@aborgna-q
refactor: Move python bindings from tket2 to tket2-py (#235)
57bd11f 
Adds transparent wrappers on `tket2-py` that derive pyclass themselves.
This has multiple goals:

- Cleans up the code. Python stuff goes into the python crate.
Now `tket2:pyo3` and `hugr:pyo3` are only used for the python error
implementations.
(We could potentially move this too, and avoid us the `pyo3` dependency
headache).
  
- Let's us use the `tket2-py` conversion methods for tket1 and tket2
circuits. This is required for #178, which is in turn required for all
the python bindings in #204 that require stable indices.

Closes #148 

---

The code is mostly the same, asides from:
- replacing the custom implementation of `PyPatternMatch` with a
transparent wrapper. (There was a TODO for this).
- updating to tket-json-rs 0.3 (cleans up some calls that use
`Python::with_gil`)
@aborgna-q aborgna-q added python Pull requests that update Python code and removed py-bindings Python bindings labels Oct 23, 2024
@aborgna-q
Copy link
Collaborator Author

Closing this in favour of #671

@aborgna-q aborgna-q unpinned this issue Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
python Pull requests that update Python code tracking-issue An issue tracking progress on multiple sub-tasks.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aborgna-q