Allow any op as root #112
Merged
Allow any op as root #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqc-alec
reviewed
Jun 1, 2023
aborgna-q
reviewed
Jun 1, 2023
There was a problem hiding this comment.
I think there are some expects in the validation that may fail when unwrapping a parent if the node is the root (esp. in validate_intergraph_edge).
We could check that the root has no connections, but what is checked first depend on the traversal order for the node validation.
Also, I don't see where the new Options on the builder wrappers come into play.
Otherwise, this looks nice.
Merged
to allow for building non-module root HUGR for now only adds DFG builder at root level, other containers to come
for Module and DFG
|
Have left compositional building via graph inserting as a follow up task #120 |
Co-authored-by: Agustín Borgna <[email protected]>
mostly docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to allow for building non-module root HUGR
Closes #82