Skip to content

Ensure finish() called on builders before dropped #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ss2165 opened this issue Jun 5, 2023 · 0 comments
Open

Ensure finish() called on builders before dropped #115

ss2165 opened this issue Jun 5, 2023 · 0 comments
Labels
breaking-change Changes that break semver enhancement New feature or request

Comments

@ss2165
Copy link
Member

ss2165 commented Jun 5, 2023

Currently finish() implementations just perform local validation checks and then return a handle. If they do more serious things like complete the build (actually mutate the HUGR) we may want a mechanism to ensure it is called before the builder is dropped (indeed, that finish() is the only way to drop the builder). However, this is now wondering in to linear types, so: rust-lang/rfcs#814

@ss2165 ss2165 added the P-low label Jun 5, 2023
@ss2165 ss2165 added the enhancement New feature or request label Jun 5, 2023
@croyzor croyzor self-assigned this Sep 20, 2023
@aborgna-q aborgna-q added the breaking-change Changes that break semver label Mar 14, 2024
@aborgna-q aborgna-q removed the P-low label May 15, 2024
@croyzor croyzor removed their assignment Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Changes that break semver enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants