Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

fix: remove wildcard (*) dependency constraint for crate publishing #105

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

qartik
Copy link
Member

@qartik qartik commented Sep 16, 2024

Also sanitizes the READMEs a bit.

The last attempt to publish a crate using release PR #98 failed with:

error: failed to publish to registry at https://crates.io/
    
    Caused by:
      the remote server responded with an error (status 400 Bad Request): wildcard (`*`) dependency constraints are not allowed on crates.io. Crate with this problem: `serde` See https://doc.rust-lang.org/cargo/faq.html#can-libraries-use--as-a-version-for-their-dependencies for more information

@qartik qartik requested a review from a team as a code owner September 16, 2024 17:24
@qartik qartik marked this pull request as draft September 16, 2024 17:27
@qartik qartik marked this pull request as draft September 16, 2024 17:27
also sanitizes the READMEs a bit
@qartik qartik marked this pull request as ready for review September 16, 2024 17:28
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.54%. Comparing base (1fdc898) to head (549b554).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #105   +/-   ##
=======================================
  Coverage   83.54%   83.54%           
=======================================
  Files          26       26           
  Lines        4016     4016           
  Branches     4016     4016           
=======================================
  Hits         3355     3355           
  Misses        343      343           
  Partials      318      318           
Flag Coverage Δ
rust 83.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qartik qartik added the bug Something isn't working label Sep 16, 2024
@qartik qartik self-assigned this Sep 16, 2024
@qartik qartik linked an issue Sep 16, 2024 that may be closed by this pull request
@qartik qartik enabled auto-merge September 16, 2024 19:20
@qartik qartik added this pull request to the merge queue Sep 17, 2024
Copy link
Collaborator

@doug-q doug-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Merged via the queue into main with commit 21dbefe Sep 17, 2024
12 checks passed
@qartik qartik deleted the fix-0.5-release branch September 17, 2024 08:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.5.0 release not published
3 participants