Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Allow commands to fail using configuration #460

Merged
merged 4 commits into from
Jan 29, 2024

Conversation

eliashaeussler
Copy link
Member

@eliashaeussler eliashaeussler commented Jan 29, 2024

This PR introduces a new configuration option allowFailure for the runCommand step. It allows to continue the normal project generation process even in cases of command execution failures.

@eliashaeussler eliashaeussler added the enhancement New feature or request label Jan 29, 2024
@eliashaeussler eliashaeussler requested a review from mteu January 29, 2024 10:39
@eliashaeussler eliashaeussler self-assigned this Jan 29, 2024
Copy link

codeclimate bot commented Jan 29, 2024

Code Climate has analyzed commit 885fb48 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 96.4% (0.0% change).

View more on Code Climate.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (743e5b3) 96.48% compared to head (885fb48) 96.48%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #460   +/-   ##
=========================================
  Coverage     96.48%   96.48%           
- Complexity      699      701    +2     
=========================================
  Files           101      101           
  Lines          2217     2219    +2     
=========================================
+ Hits           2139     2141    +2     
  Misses           78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mteu mteu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering as to why you chose to call the option in plural instead of simply allowFailure?

Apart form that LGTM. I've updated documentation to reflect the new option in the runCommand step.

@mteu mteu force-pushed the feature/allow-failure branch from cb14cb7 to edef33a Compare January 29, 2024 12:10
@eliashaeussler
Copy link
Member Author

I was wondering as to why you chose to call the option in plural instead of simply allowFailure?

Apart form that LGTM. I've updated documentation to reflect the new option in the runCommand step.

@mteu Thanks for the documentation part! I totally missed that. I'll adjust naming of the configuration option as well.

@eliashaeussler eliashaeussler merged commit 288f52e into main Jan 29, 2024
45 checks passed
@eliashaeussler eliashaeussler deleted the feature/allow-failure branch January 29, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants