-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Allow commands to fail using configuration #460
Conversation
1243df3
to
2b332c0
Compare
Code Climate has analyzed commit 885fb48 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 96.4% (0.0% change). View more on Code Climate. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #460 +/- ##
=========================================
Coverage 96.48% 96.48%
- Complexity 699 701 +2
=========================================
Files 101 101
Lines 2217 2219 +2
=========================================
+ Hits 2139 2141 +2
Misses 78 78 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering as to why you chose to call the option in plural instead of simply allowFailure
?
Apart form that LGTM. I've updated documentation to reflect the new option in the runCommand
step.
cb14cb7
to
edef33a
Compare
@mteu Thanks for the documentation part! I totally missed that. I'll adjust naming of the configuration option as well. |
Co-authored-by: Martin Adler <[email protected]>
This PR introduces a new configuration option
allowFailure
for therunCommand
step. It allows to continue the normal project generation process even in cases of command execution failures.