Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Disallow symfony/console 7.x for the time being #458

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

eliashaeussler
Copy link
Member

Composer < 2.7 is not and won't ever be compatible with symfony/console 7.x (see composer/composer#11741 (comment)). An appropriate "fix" was added with Composer 2.6.6 where symfony/console 7.x was explicitly disallowed. Since we allow symfony/console 7.x in Composer environments which are most likely not compatible with said version, we now explicitly remove support for symfony/console 7.x. We'll re-add it later if most people have upgraded to a more recent version where stable support for symfony/console 7.x is guaranteed.

@eliashaeussler eliashaeussler added the bug Something isn't working label Jan 26, 2024
@eliashaeussler eliashaeussler requested a review from mteu January 26, 2024 15:22
@eliashaeussler eliashaeussler self-assigned this Jan 26, 2024
Copy link

codeclimate bot commented Jan 26, 2024

Code Climate has analyzed commit 7b56e1e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 96.4% (0.0% change).

View more on Code Climate.

@mteu mteu merged commit effedfc into main Jan 26, 2024
42 checks passed
@mteu mteu deleted the fix/symfony-console-v7 branch January 26, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants