Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] s3 presignedUrl 발급 기능 구현 #84

Merged
merged 13 commits into from
Feb 6, 2024
Merged

Conversation

k-kbk
Copy link
Collaborator

@k-kbk k-kbk commented Jan 10, 2024

해당 PR이 어떤 것을 하나요?

  • presignedUrl 발급
    • put: 업로드
    • get: 조회

고민(선택)

기획 문서 혹은 태스크 관련 링크

@k-kbk k-kbk changed the title [feat] s3 presignedUrl 발급 기능 구현 [feature] s3 presignedUrl 발급 기능 구현 Jan 10, 2024
@k-kbk k-kbk added the feature 기능 개발 및 테스트 작성 label Jan 10, 2024
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (7698d47) 91.69% compared to head (e36c50d) 88.73%.
Report is 1 commits behind head on main.

❗ Current head e36c50d differs from pull request most recent head 1a0a2ad. Consider uploading reports for the commit 1a0a2ad to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #84      +/-   ##
============================================
- Coverage     91.69%   88.73%   -2.97%     
- Complexity      374      378       +4     
============================================
  Files            74       78       +4     
  Lines           867      914      +47     
  Branches         24       24              
============================================
+ Hits            795      811      +16     
- Misses           58       89      +31     
  Partials         14       14              
Files Coverage Δ
.../kotlin/com/mjucow/eatda/common/config/S3Config.kt 100.00% <100.00%> (ø)
.../com/mjucow/eatda/domain/s3/dto/PresignedUrlDto.kt 0.00% <0.00%> (ø)
...n/com/mjucow/eatda/presentation/s3/S3Controller.kt 37.50% <37.50%> (ø)
...in/com/mjucow/eatda/domain/s3/service/S3Service.kt 14.81% <14.81%> (ø)

@dojinyou dojinyou merged commit 8676f3e into main Feb 6, 2024
3 checks passed
@dojinyou dojinyou deleted the image-upload branch February 6, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 기능 개발 및 테스트 작성 size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants