-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] s3 presignedUrl 발급 기능 구현 #84
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-kbk
changed the title
[feat] s3 presignedUrl 발급 기능 구현
[feature] s3 presignedUrl 발급 기능 구현
Jan 10, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
============================================
- Coverage 91.69% 88.73% -2.97%
- Complexity 374 378 +4
============================================
Files 74 78 +4
Lines 867 914 +47
Branches 24 24
============================================
+ Hits 795 811 +16
- Misses 58 89 +31
Partials 14 14
|
dojinyou
reviewed
Jan 11, 2024
src/main/kotlin/com/mjucow/eatda/domain/s3/dto/PresignedUrlDto.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/mjucow/eatda/domain/s3/service/S3Service.kt
Outdated
Show resolved
Hide resolved
dojinyou
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
해당 PR이 어떤 것을 하나요?
고민(선택)
기획 문서 혹은 태스크 관련 링크