Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] expired banner migration job 구현 #68

Merged
merged 4 commits into from
Nov 30, 2023
Merged

Conversation

dojinyou
Copy link
Member

@dojinyou dojinyou commented Nov 28, 2023

해당 PR이 어떤 것을 하나요?

  • 만료된 banner 테이블 정리하는 job을 구현합니다

고민(선택)

기획 문서 혹은 태스크 관련 링크

@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 29, 2023
@dojinyou dojinyou changed the title [feat] expired banner migration job 구현 [feature] expired banner migration job 구현 Nov 29, 2023
@github-actions github-actions bot added the feature 기능 개발 및 테스트 작성 label Nov 29, 2023
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #68 (5a8a875) into main (e70bc76) will increase coverage by 0.37%.
Report is 6 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #68      +/-   ##
============================================
+ Coverage     92.89%   93.27%   +0.37%     
- Complexity      355      364       +9     
============================================
  Files            69       71       +2     
  Lines           732      773      +41     
  Branches         22       23       +1     
============================================
+ Hits            680      721      +41     
  Misses           38       38              
  Partials         14       14              
Files Coverage Δ
...om/mjucow/eatda/scheduled/ExpiredBannerBatchJob.kt 100.00% <100.00%> (ø)
...in/com/mjucow/eatda/scheduled/ScheduleJobConfig.kt 100.00% <100.00%> (ø)

@dojinyou dojinyou enabled auto-merge (squash) November 29, 2023 16:04
@dojinyou dojinyou merged commit bfe0390 into main Nov 30, 2023
5 checks passed
@dojinyou dojinyou deleted the feat/banner-batch branch November 30, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 기능 개발 및 테스트 작성 size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants