Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 동아리원 명단 수정 기능 변경 #43

Merged
merged 17 commits into from
Feb 10, 2024

Conversation

5uhwann
Copy link
Collaborator

@5uhwann 5uhwann commented Feb 10, 2024

🚀 작업 내용

  • 동아리원 명단 수정 기능 변경
    • as-is: json
    • to-be: xlsx 파일

🤔 고민했던 내용

💬 리뷰 중점사항

5uhwann and others added 16 commits August 23, 2023 04:55
docs : 기술 스택 업데이트
Co-authored-by: 5uhwann <[email protected]>
Co-authored-by: MinsuKim <[email protected]>
# Conflicts:
#	.github/workflows/ddingdong-dev-deploy.yml
#	build.gradle
#	src/main/java/ddingdong/ddingdongBE/domain/club/repository/ClubMemberRepository.java
#	src/main/java/ddingdong/ddingdongBE/domain/club/service/ClubMemberService.java
docs : 기술 스택 업데이트
# Conflicts:
#	src/main/java/ddingdong/ddingdongBE/domain/club/service/ClubMemberService.java
@5uhwann 5uhwann added the 🎯리팩토링 리팩토링 및 고도화 이슈 label Feb 10, 2024
@5uhwann 5uhwann self-assigned this Feb 10, 2024
Copy link

codecov bot commented Feb 10, 2024

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (ca72add) 5.89% compared to head (e650aba) 5.75%.

❗ Current head e650aba differs from pull request most recent head 987f1d4. Consider uploading reports for the commit 987f1d4 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             develop     #43      +/-   ##
============================================
- Coverage       5.89%   5.75%   -0.14%     
  Complexity        36      36              
============================================
  Files             92      92              
  Lines           1460    1494      +34     
  Branches          59      63       +4     
============================================
  Hits              86      86              
- Misses          1374    1408      +34     
Files Coverage Δ
...main/club/controller/CentralClubApiController.java 0.00% <0.00%> (ø)
...ngdongBE/common/exception/ExceptionController.java 0.00% <0.00%> (ø)
...ain/club/controller/dto/request/ClubMemberDto.java 0.00% <0.00%> (ø)
...gdongBE/domain/club/service/ClubMemberService.java 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca72add...987f1d4. Read the comment docs.

@5uhwann 5uhwann merged commit 8f1f435 into develop Feb 10, 2024
@5uhwann 5uhwann deleted the refactor/동아리원_업데이트_엑셀 branch July 1, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯리팩토링 리팩토링 및 고도화 이슈
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants