Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Unique names for the pattern {parent_banch_name}.{branch_name} #799

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jdacoello
Copy link
Contributor

Addresses the issue #797 .

@erikbosch
Copy link
Collaborator

MoM:

  • Daniel presented the change
  • Deprecation included so we could release it as part of a minor release
  • Erik: Deprecation not needed if we intend to release it only as 6.0
  • Please review!

spec/Cabin/Seat.vspec Outdated Show resolved Hide resolved
spec/Cabin/Seat.vspec Outdated Show resolved Hide resolved
spec/Cabin/Seat.vspec Outdated Show resolved Hide resolved
@erikbosch
Copy link
Collaborator

I took a quick look. In general I think the approach of removing the "switch" sub-branch makes sense.

A side-note for switches. In VSS we typically have for each seat attribute (e.g. headrest tilt) have 3 data, position (absolute value in mm/degrees or relative in percent) and two "switches" for more/less. In Android VHAL they have a partially different representation with two data, position and "speed", the advantage is that you can represent how fast you want the seat to move.

Operation Android VSS
Move to a specific position Set SEAT_BACKREST_ANGLE_1_POS Set Backrest.Recline
Move forward Set SEAT_BACKREST_ANGLE_2_MOVE to a positive value Set Backrest.IsReclineForwardSwitchEngaged to True
Move backward Set SEAT_BACKREST_ANGLE_2_MOVE to a negative value Set Backrest.IsReclineBackwardSwitchEngaged to True

@jdacoello
Copy link
Contributor Author

A side-note for switches... you can represent how fast you want the seat to move

@erikbosch Interesting that you mention this feature. Specifying custom arguments for the properties is natively supported by the GraphQL Schema Language.

type Seat {
  isReclineForwardSwitchEngaged(mechanismSpeed: SeatReclineSpeed = MEDIUM): Boolean
}

enum SeatReclineSpeed {
  SLOW
  MEDIUM
  FAST
}

You can see how things are still connected, even when they are maintained separately. In current VSS, we would need two different data points (or an struct) to convey the same meaning.

@jdacoello jdacoello force-pushed the feat-unique-names-parent-plus-branch branch 2 times, most recently from ab39e58 to 1ccfdb6 Compare December 18, 2024 12:59
@jdacoello jdacoello force-pushed the feat-unique-names-parent-plus-branch branch from 1ccfdb6 to a128d87 Compare December 18, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants