-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Unique names for the pattern {parent_banch_name}.{branch_name} #799
base: master
Are you sure you want to change the base?
refactor: Unique names for the pattern {parent_banch_name}.{branch_name} #799
Conversation
MoM:
|
I took a quick look. In general I think the approach of removing the "switch" sub-branch makes sense. A side-note for switches. In VSS we typically have for each seat attribute (e.g. headrest tilt) have 3 data, position (absolute value in mm/degrees or relative in percent) and two "switches" for more/less. In Android VHAL they have a partially different representation with two data, position and "speed", the advantage is that you can represent how fast you want the seat to move.
|
@erikbosch Interesting that you mention this feature. Specifying custom arguments for the properties is natively supported by the type Seat {
isReclineForwardSwitchEngaged(mechanismSpeed: SeatReclineSpeed = MEDIUM): Boolean
}
enum SeatReclineSpeed {
SLOW
MEDIUM
FAST
} You can see how things are still connected, even when they are maintained separately. In current VSS, we would need two different data points (or an struct) to convey the same meaning. |
ab39e58
to
1ccfdb6
Compare
Signed-off-by: Daniel Alvarez-Coello <[email protected]>
1ccfdb6
to
a128d87
Compare
Addresses the issue #797 .