Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not block UI when building ECUs tree #606

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

vifactor
Copy link
Collaborator

This PR resolves #576 for the cases when DLT log contains lots of apps and contexts.

Historically, the same function used to populate ECU tree (in the "Config"-tab) both in online and offline modes. This was a problem for offline mode (aka dlt-file loading), because UI update is then called multiple time in a short time frame ate the end of file processing freezing the whole app. The fix is to:

  1. Separate parsing of control messages payloads from UI creation
  2. When tree view is created use more efficient constructors, which do not force many redundant UI updates.

}
project.ecu->clear();
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexmucde this changes this behavior: #576 (comment) I.e. now every new dlt file import will clean up the ECU tree first and create new one only with its own entries.

This makes this change a bit simpler, unless old behavior was intentional.

@vifactor
Copy link
Collaborator Author

@alexmucde I would appreciate if you could play with this. I tried not to bring any regressions, but as you can see the change is not small, so I might have introduced some. Also I would appreciate if you could provide data for tests to make them more robust, e.g. raw data to check parsing of other types of payloads except GetLogInfo

@vifactor vifactor added this to the Release v2.28.0 milestone Dec 23, 2024
@vifactor vifactor requested a review from alexmucde December 23, 2024 16:38
@vifactor vifactor force-pushed the parse-ctrl-msg branch 3 times, most recently from ab12c71 to f8f3d7d Compare December 23, 2024 20:07
@vifactor vifactor marked this pull request as ready for review December 23, 2024 21:21
use ctrlmsg parsing function

add test

Signed-off-by: Viktor Kopp <[email protected]>
fix symbols visibility

Fix macos-13 build

It still uses qmake, so new sources should be added there too

Signed-off-by: Viktor Kopp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI is unresponsive for seconds at the end of dlt load
1 participant