Cleanup the code related to ECUs tree populating functionality #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vifactor I plan to freeze the code until end of this week for the next release 2.27.0, afterwards only bug fixing. Please provide all feature updates until end of this week. |
|
@alexmucde thanks for notifying me, noted. I'll try to test more this one, no new features or refactorings on my side so far. |
vifactor
force-pushed
the
ui-freeze-on-load
branch
2 times, most recently
from
5d0eeef to
6a40cae
Compare
vifactor
changed the title
|
This can be merged to the next version after 2.27 freeze. I'll change the label then. |
vifactor
changed the title
vifactor
force-pushed
the
ui-freeze-on-load
branch
from
d0ae448 to
467d309
Compare
vifactor
force-pushed
the
ui-freeze-on-load
branch
from
467d309 to
3fc04cb
Compare
- Fix couple of warnings - Minor cleanup of dead code - Const-correctness for a couple of funcs Signed-off-by: Viktor Kopp <[email protected]>
We are looping over messages which satisfy this condition since they were filtered in indexer, see DltFileIndexerThread::processMessage method Signed-off-by: Viktor Kopp <[email protected]>
Signed-off-by: Viktor Kopp <[email protected]>
vifactor
force-pushed
the
ui-freeze-on-load
branch
from
3fc04cb to
4ee0541
Compare
Use new EcuItem::find method where possible Signed-off-by: Viktor Kopp <[email protected]>
vifactor
force-pushed
the
ui-freeze-on-load
branch
from
4ee0541 to
5081dc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are very minor improvements that I could so far make working on #576
Nonfunctional changes, just some easy cleanups.