Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all track2kml-ext related code in track2kml #7

Merged
merged 8 commits into from
Apr 1, 2024
Merged

Remove all track2kml-ext related code in track2kml #7

merged 8 commits into from
Apr 1, 2024

Conversation

marcasmar1
Copy link
Contributor

No description provided.

marcasmar1
marcasmar1 commented Mar 16, 2024
View reviewed changes
cli/CHANGELOG.md Outdated Show resolved Hide resolved
@marcasmar1
Copy link
Contributor Author

track2kml-ext is linked to track2kml, among other things, through the Format type. If we brake compatibilty with track2kml-ext, this code could be drastically simplified at the expense of having to rewrite the way track2kml functions internally. The code is written in a way that takes into account the posibility of multiple input formats, which seems redundant going forward, but it's probably unnecessary to update the code.

aleokdev
aleokdev reviewed Mar 17, 2024
View reviewed changes
cli/CHANGELOG.md Outdated Show resolved Hide resolved
cli/CHANGELOG.md Outdated Show resolved Hide resolved
cli/CHANGELOG.md Outdated Show resolved Hide resolved
cli/src/lib.rs Outdated Show resolved Hide resolved
cli/src/lib.rs Outdated Show resolved Hide resolved
cli/src/lib.rs Outdated Show resolved Hide resolved
aleokdev
aleokdev reviewed Mar 17, 2024
View reviewed changes
cli/src/lib.rs Outdated Show resolved Hide resolved
@aleokdev aleokdev merged commit 9dd87cb into main Apr 1, 2024
2 checks passed
@aleokdev aleokdev deleted the remove-track2kml-ext branch April 1, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleokdev aleokdev aleokdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcasmar1 @aleokdev