-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync scheduler overhaul #15
base: main
Are you sure you want to change the base?
Conversation
Good stuff, looking forward to getting this up and running. |
Its hard to tell what parts of this is actually changing functionality because 99% of the diff is just changing the code formatting. (the new formatting is also harder to read than the old formatting) |
I think a lot of this is refactoring to make it easier to add/change functionality later. We still need to do some work on manual sync before it's up and running, we're also experiencing a lot of #13 in production. |
why did you change all the function definitions to the following format? auto Schedule::getInstance() -> Schedule* this is WAY harder to read especially for newer students. Also I like to avoid auto (except for some cases like range for loops). Also I am resisting the urge to nitpick all of the other weird formatting but I couldn't ignore this. |
…nv instead of putenv
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the overall structure. I've highlighted a few formatting things that stood out to me, but once reaping is fixed I don't see any reason this couldn't be merged.
…han using process groups
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we convert dry run to an environment variable to match sync port, or vice-versa?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should readme.md be capitalized
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As before, my comments are just on formatting/ consistency. After reading everyting over, and since it seems to be running fine on elephant, I don't see any reason this can't be merged.
No description provided.