Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync scheduler overhaul #15

Open
wants to merge 128 commits into
base: main
Choose a base branch
from
Open

sync scheduler overhaul #15

wants to merge 128 commits into from

Conversation

carykees98
Copy link
Collaborator

No description provided.

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler
@lavajuno
Copy link
Collaborator

Good stuff, looking forward to getting this up and running.

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler
@Warvan1
Copy link
Member

Warvan1 commented Nov 21, 2024

Its hard to tell what parts of this is actually changing functionality because 99% of the diff is just changing the code formatting. (the new formatting is also harder to read than the old formatting)

@lavajuno
Copy link
Collaborator

I think a lot of this is refactoring to make it easier to add/change functionality later. We still need to do some work on manual sync before it's up and running, we're also experiencing a lot of #13 in production.

@Warvan1
Copy link
Member

Warvan1 commented Nov 21, 2024

why did you change all the function definitions to the following format?

auto Schedule::getInstance() -> Schedule*
{
//code
}

this is WAY harder to read especially for newer students. Also I like to avoid auto (except for some cases like range for loops).

Also I am resisting the urge to nitpick all of the other weird formatting but I couldn't ignore this.

@carykees98 carykees98 linked an issue Feb 7, 2025 that may be closed by this pull request
carykees98 and others added 23 commits February 7, 2025 02:54

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler
…nue to forget)

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler

Verified

This commit was signed with the committer’s verified signature.
brendanjconnelly Brendan Connelly

Partially verified

This commit is signed with the committer’s verified signature.
brendanjconnelly’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.

Partially verified

This commit is signed with the committer’s verified signature.
brendanjconnelly’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.

Partially verified

This commit is signed with the committer’s verified signature.
brendanjconnelly’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.

Partially verified

This commit is signed with the committer’s verified signature.
brendanjconnelly’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.

Partially verified

This commit is signed with the committer’s verified signature.
brendanjconnelly’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler
…nv instead of putenv

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler
Copy link
Member

@aHalliday13 aHalliday13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the overall structure. I've highlighted a few formatting things that stood out to me, but once reaping is fixed I don't see any reason this couldn't be merged.

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler
…rmation about

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler
…han using process groups

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler
@carykees98 carykees98 requested a review from aHalliday13 March 27, 2025 19:00
@carykees98 carykees98 linked an issue Mar 27, 2025 that may be closed by this pull request

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler

Verified

This commit was signed with the committer’s verified signature.
carykees98 Cary Keesler
Copy link
Member

@aHalliday13 aHalliday13 Mar 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we convert dry run to an environment variable to match sync port, or vice-versa?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should readme.md be capitalized

Copy link
Member

@aHalliday13 aHalliday13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As before, my comments are just on formatting/ consistency. After reading everyting over, and since it seems to be running fine on elephant, I don't see any reason this can't be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to request manual sync via API endpoint Sync scheduler does not properly reap child processes
5 participants