Merge pull request #123 from jaclyn-taroni/jaclyn-taroni/fix-overview… #440
rust.yml
on: push
Matrix: build
Matrix: Formatting
Matrix: Linting
Matrix: sample_run
Annotations
5 errors and 6 warnings
redundant redefinition of a binding:
src/quant.rs#L538
error: redundant redefinition of a binding
--> src/quant.rs:538:9
|
538 | let bc_type = rad_types::decode_int_type_tag(bct).expect("unsupported barcode type id.");
| ^^^^^^^
...
640 | let bc_type = bc_type;
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: remove the redefinition of `bc_type`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_locals
= note: `#[deny(clippy::redundant_locals)]` on by default
|
redundant redefinition of a binding:
src/quant.rs#L539
error: redundant redefinition of a binding
--> src/quant.rs:539:9
|
539 | let umi_type = rad_types::decode_int_type_tag(umit).expect("unsupported umi type id.");
| ^^^^^^^^
...
641 | let umi_type = umi_type;
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: remove the redefinition of `umi_type`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_locals
|
Linting (ubuntu-latest)
Clippy had exited with the 101 exit code
|
Linting (macos-latest)
The job was canceled because "ubuntu-latest" failed.
|
Linting (macos-latest)
The operation was canceled.
|
Linting (ubuntu-latest)
Unexpected input(s) 'token', valid inputs are ['toolchain', 'args', 'use-cross']
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
src/collate.rs#L121
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> src/collate.rs:121:38
|
121 | let mut tsv_map = Vec::from_iter(freq_hm.into_iter());
| ^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `freq_hm`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/collect.rs:149:21
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
useless use of `vec!`:
src/convert.rs#L45
warning: useless use of `vec!`
--> src/convert.rs:45:16
|
45 | let nucl = vec!["A", "T", "G", "C"];
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["A", "T", "G", "C"]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
= note: `#[warn(clippy::useless_vec)]` on by default
|
use of `or_insert_with` to construct default value:
src/pugutils.rs#L297
warning: use of `or_insert_with` to construct default value
--> src/pugutils.rs:297:46
|
297 | let ve = components.entry(*v as u32).or_insert_with(Vec::new);
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
= note: `#[warn(clippy::unwrap_or_default)]` on by default
|
use of `or_insert_with` to construct default value:
src/pugutils.rs#L818
warning: use of `or_insert_with` to construct default value
--> src/pugutils.rs:818:42
|
818 | let umis = tmp_map.entry(vert.0).or_insert_with(Vec::new);
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
|
Linting (macos-latest)
Unexpected input(s) 'token', valid inputs are ['toolchain', 'args', 'use-cross']
|