Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let Dataset use directory lock #147

Merged
merged 6 commits into from
Jan 13, 2021
Merged

Let Dataset use directory lock #147

merged 6 commits into from
Jan 13, 2021

Conversation

xuhdev
Copy link
Collaborator

@xuhdev xuhdev commented Jan 9, 2021

Each Dataset method that may modify or read the data directory will be
integrated with directory locks.


Checklist:

  • Does this pull request close an issue? We encourage you to open an issue first if this pull request (PR) is not a
    minor change.
    • No
      • The change in this pull request is minor.
    • Yes
      • Close #{internal}

For the following questions, only check the boxes that are applicable.

  • Ensure that the pull request text above the horizontal line is descriptive.

  • Add/update relevant tests.

  • Add/update relevant documents.

  • Do you have triage permission of this repository?

    • No
      • You are good.
    • Yes
      • Does this pull request close an issue?
        • No, this pull request also acts as an issue by itself.
          • Assign yourself.
          • Label this pull request.
          • Put a milestone.
          • Put this pull request under "In Progress" or "Under Review" pipeline on ZenHub.
          • Put this pull request under the appropriate epic on ZenHub.
          • Put an estimate on ZenHub.
          • Add dependency relationship with other issues/pull requests on ZenHub.
        • Yes, this pull request addresses an issue and does not act as an issue.
          • Connect this pull request to the underlying issue on ZenHub.
          • DON'T:
            • DON'T assign yourself or anyone else.
            • DON'T label.
            • DON'T put a milestone.
            • DON'T put this pull request under any epic on ZenHub.
            • DON'T put an estimate on ZenHub.
      • When the pull request is ready, request review.

@xuhdev xuhdev force-pushed the lock branch 7 times, most recently from 5e5019c to ee922b8 Compare January 9, 2021 04:49
@xuhdev xuhdev requested a review from edwardleardi January 9, 2021 04:54
Each Dataset method that may modify or read the data directory will be
integrated with directory locks.
Copy link
Collaborator

@edwardleardi edwardleardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@edwardleardi edwardleardi self-requested a review January 13, 2021 17:57
Copy link
Collaborator

@edwardleardi edwardleardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You didn't request a followup review, so I wasn't sure if this is ready to merge. Feel free to merge yourself if it's ready.

@xuhdev xuhdev merged commit b956ac3 into master Jan 13, 2021
@xuhdev xuhdev deleted the lock branch January 13, 2021 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants