Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data formats tutorial #3

Draft
wants to merge 31 commits into
base: main
Choose a base branch
from
Draft

Conversation

EugenePlanteurCS
Copy link

No description provided.

@EugenePlanteurCS EugenePlanteurCS changed the title Data fromats tutorial Data formats tutorial Nov 19, 2024
"source": [
"With only the second overview, the time needed to load the data into memory is divided by a factor of approximately 10 (this factor may vary depending on the machine you are using). The displayed image is the data loaded from the last overview (the one with the lowest resolution).\n",
"\n",
"## Conclusion\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this tutorial : it's simple and well explained. But maybe it would be interesting to leave user try with a bigger image, because with such size of images, it's hard to see differences.
Could you at least mention the read time and the size of a much bigger image (such as a full S2 product ?) ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your feedback. I used this image because it could be automatically downloaded with a script. I couldn't find a full S2 image available for download without requiring an account on a provider’s website, which would have added complexity to the tutorial. Additionally, such an image would be too large to host directly in the repo.

I can add a subsection with read/write times and file sizes for all formats based on my tests I did with a real S2 image. I'll then include a short paragraph inviting users to download data from a provider and running the same benchmarks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably find or add that, for example sharing the image on Zenodo.

Copy link
Member

@guillaumeeb guillaumeeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a review on the optimization notebook for now.

Shouldn't we publish cleaned notebook for clarity?

data_type/readme.md Outdated Show resolved Hide resolved
data_type/readme.md Outdated Show resolved Hide resolved
data_type/data_optimization.ipynb Outdated Show resolved Hide resolved
data_type/data_optimization.ipynb Outdated Show resolved Hide resolved
data_type/data_optimization.ipynb Outdated Show resolved Hide resolved
data_type/data_optimization.ipynb Outdated Show resolved Hide resolved
data_type/data_optimization.ipynb Outdated Show resolved Hide resolved
data_type/data_optimization.ipynb Outdated Show resolved Hide resolved
data_type/data_optimization.ipynb Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants