Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed color of text and buttons to black #121

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

changed color of text and buttons to black #121

wants to merge 4 commits into from

Conversation

huiningliang
Copy link
Collaborator

Because the background is a very light shade, changing the buttons to a dark color such as black should make it more obvious to users.

@huiningliang huiningliang added this to the HW1 milestone Sep 9, 2021
@huiningliang
Copy link
Collaborator Author

Resolved #82
Accessibility score has increased from 77 to 79; Colors of the instruction text as well as the cancel button are now changed to black, which is considerably more visible than the original light gray(?). The lighthouse score did improve, but not significantly, which is understandable given the size and difficulty of resolving this issue. The phrase "style = "color: black"" was added behind the lines related to the two recommended error locations, which changed the text color to black in both places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
accessibility
Projects
None yet
Milestone
HW1
Development

Successfully merging this pull request may close these issues.
1 participant
@huiningliang