Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Estimated readtime function in node_modules/nodebb-theme-harmony/templates/partials/topic/post.tpl #50

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

ssaigh
Copy link

@ssaigh ssaigh commented Oct 18, 2024

The pull request resolves the issue #45 (Calculation Logic for Estimated Reading Time)

File: node_modules/nodebb-theme-harmony/templates/partials/topic/post.tpl
Goal: Implement a function that would help in presenting the estimated reading time

Changes:
-Added a function calculate the reading time (), which calculates the word count and the reading time based on average reading speed.

@ssaigh ssaigh requested a review from edemenkov October 18, 2024 15:22
@ssaigh ssaigh changed the title Added Estimated readtime function in post.tpl in topics Added Estimated readtime function in topics/post.tpl Oct 19, 2024
@ssaigh ssaigh changed the title Added Estimated readtime function in topics/post.tpl Added Estimated readtime function in node_modules/nodebb-theme-harmony/templates/partials/topic/post.tpl Oct 19, 2024
@ssaigh ssaigh added this to the Sprint 2 milestone Oct 20, 2024
@edemenkov edemenkov added the enhancement New feature or request label Oct 20, 2024
@edemenkov edemenkov linked an issue Oct 20, 2024 that may be closed by this pull request
@edemenkov
Copy link

Looks fine, great that user doesnt need to reload anymore in order to see the estimated time, as it was before.
So, great improvement of the function, looks more clean and efficient.

Well done

@jdufitum jdufitum self-requested a review October 20, 2024 18:44
Copy link

@jdufitum jdufitum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdufitum jdufitum merged commit 6b7470f into CMU-17313Q:f24 Oct 20, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calculation Logic for Estimated Reading Time
3 participants