Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the search button in the menu bar - for keyword search #33

Open
wants to merge 1 commit into
base: f24
Choose a base branch
from

Conversation

kwarraich
Copy link
Collaborator

@kwarraich kwarraich commented Sep 26, 2024

Integrated the Search Button into the Tool List Bar on the General Discussion page.

  • Updated .gitignore so changes in .tpl file were actually shown.
  • Utilized the pre-existing search bar in users.tpl
  • Added the search button in tool-list-bar.tpl so it may be used to trigger the search functionality

This enhancement improves the user experience by making the search button so that way users can actually gain from searching

Resolving Issue #21

@kwarraich kwarraich requested a review from khalifat3 September 26, 2024 14:15
@kwarraich kwarraich self-assigned this Sep 26, 2024
@Abdallah-Abdaljalil Abdallah-Abdaljalil added enhancement New feature or request frontEnd Issues with frontend labels Sep 26, 2024
@Abdallah-Abdaljalil
Copy link
Collaborator

Abdallah-Abdaljalil commented Sep 26, 2024

Integrated the Search Button into the Tool List Bar on the General Discussion page.

-Updated .gitignore so changes in .tpl file were actually shown.

  • Utilized the pre-existing search bar in users.tpl
  • Added the search button in tool-list-bar.tpl so it may be used to trigger the search functionality

This enhancement improves the user experience by making the search button so that way users can actually gain from searching

Resolving Issue #21

For this pull request, the advanced search feature Raman was implementing includes a search bar and a button, and we agreed that one suited the page better, and it will allow Raman to implement his feature better in the future. This issue is only for the front end. In this situation, the tests failed as well, making it more of an incentive to not merge this at all.

@Abdallah-Abdaljalil Abdallah-Abdaljalil added this to the Sprint 1, week 2 milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontEnd Issues with frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants