Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrating Reem's feature #5

Open
wants to merge 10,000 commits into
base: f24
Choose a base branch
from
Open

Integrating Reem's feature #5

wants to merge 10,000 commits into from

Conversation

rkensouh
Copy link

Adding Reem's individual changes from project 1 to the team project.

barisusakli and others added 30 commits April 12, 2024 16:25
@barisusakli
fix: add canView check to /api/v3/users/:uid
5bee324
@nodebb-misty
Latest translations and fallbacks
edfa402
@nodebb-misty
Latest translations and fallbacks
c5d20ba
@nodebb-misty
Latest translations and fallbacks
fe028e0
@mdorda
Add action:topic.updateTags hook (#12513)
8f317c0 
Fix NodeBB/NodeBB#12512
@barisusakli
refactor: add new hooks for notifications/websockets
d2e042d 
filter:sockets.sendNewNotificationToUid - fires before emitting "event:new_notification"

filter:sockets.sendNewPostToUid - fires before emitting "event:new_post"

filter:sockets.sendNewTopicToUid - fires before emitting "event:new_topic"

filter:user.toggleFollow- fires before follow/unfollow
@barisusakli
fix: if votes are not public, dont show upvoter names in tooltip
5af69db
@barisusakli
fix: uniqCids
de0176e
@renovate
fix(deps): update dependency sass to v1.75.0 (#12500)
f5c3d4e 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency sass-embedded to v1.75.0 (#12499)
a2229e7 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
fix(deps): update dependency ace-builds to v1.33.0 (#12501)
83a932e 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
fix(deps): update dependency nodebb-plugin-mentions to v4.5.2 (#12470)
37bdf75 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
fix(deps): update dependency nodebb-theme-harmony to v1.2.49 (#12497)
c4cb9d3 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@barisusakli
Merge branch 'master' into develop
d599493
@barisusakli
Merge branch 'develop' of https://github.com/NodeBB/NodeBB into develop
9daa7cc
@renovate
chore(deps): update dependency smtp-server to v3.13.4 (#12516)
4c468b5 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update commitlint monorepo to v19.2.2 (#12515)
97519ca 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
fix(deps): update dependency nodebb-plugin-emoji to v5.1.15 (#12517)
20f8ba7 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
fix(deps): update dependency nodebb-plugin-spam-be-gone to v2.2.2 (#1…
5b4471b 
…2518)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@nodebb-misty
Latest translations and fallbacks
0f97e16
@renovate
fix(deps): update dependency ioredis to v5.4.0 (#12519)
da0888e 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@barisusakli
fix: index should be cid
8410cec
@barisusakli
fix: zipObject
110ce66
@nodebb-misty
chore: incrementing version number - v3.7.4
c26c904
@nodebb-misty
chore: update changelog for v3.7.4
8a1b281
@renovate
fix(deps): update dependency ioredis to v5.4.1 (#12520)
66a3549 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@nodebb-misty
Latest translations and fallbacks
c7930bb
@nodebb-misty
Latest translations and fallbacks
418b025
@nodebb-misty
Latest translations and fallbacks
d85aae3
@barisusakli
fix: closes #12474, fix search dropdown on mobile for merge
ce03680 
add remove topic buttons
rohanpadhye and others added 24 commits August 18, 2024 15:47
@rohanpadhye
Ignore i18n tests in non-GitHub runs
c133faa
@rohanpadhye
Update workflows: Deploy after redis-only tests
56fd979
@rohanpadhye
README: Update badges
c0659c0
@rohanpadhye
Update workflows: Invoke tests from deploy
db7ccd3
@rohanpadhye
Fix deploy script (reuse)
8b2787e
@EduardoFF
Create volunteers.yml
09ad0fe
refactored code
589e803
@hibaabdullahhamad
Merge pull request #2 from hibaabdullahhamad/refactor_chats.js
2ff49bf 
refactored code in src/api/chats.js
fixing the function that needs to be refactored
ae5c87c
fixing some syntax issues
a388f65
@Procos12
Added Team Members
f09cf16 
Resolves #1
making project ready for tesm PR
af5b936
adding console print
ec561a6
trying to fix sonar error
86549c9
fixed conflicts with merging feature branch with syntax squads main b…
9dd5889 
…ranch
removing console
fe2f4dd
fixing testing issues
15ce234
fixing merges
8f29dbd
@rkensouh
Delete .ipynb_checkpoints/Lab2.3-UsingWebAPIs-AccuWeatherExample-Ques…
e0805bf 
…tions-checkpoint.ipynb
@rkensouh
Delete Lab2.3-UsingWebAPIs-AccuWeatherExample-Questions.ipynb
ba1e222
@rkensouh
Update configs.js
6470362
@rkensouh
Update configs.js
2998d10
@rkensouh
Update create.js
d21c997
@rkensouh
Update create.js
d613bee
@coveralls
Copy link

coveralls commented Sep 16, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10905289942

Details

  • 41 of 52 (78.85%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.06%) to 82.626%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/meta/configs.js 19 23 82.61%
src/topics/posts.js 15 22 68.18%
Files with Coverage Reduction New Missed Lines %
src/meta/configs.js 1 84.26%
src/meta/errors.js 1 76.74%
src/groups/join.js 1 92.05%
Totals Coverage Status
Change from base Build 10701387427: -0.06%
Covered Lines: 22328
Relevant Lines: 25595
💛 - Coveralls

njouud and others added 5 commits September 16, 2024 11:55
@njouud
adding refactored code changes from project1
4cbc467
@hibaabdullahhamad
Merge pull request #26 from CMU-17313Q/integrate-individual-changes
f21f0fa 
Integrate individual changes
@Procos12
Wahab's feature, Project 1 -> our repository (#30)
06c8e66 
* Refactoring srt/api/posts.js , changes from P1

Implementing the changes I made from project 1

* Update posts.js

Remove double quoted line with console.log

* Update posts.js

Fixed some syntax errors,
Block is not padded by blank lines now
@njouud
Merge pull request #31 from njouud/najouds-feature
7997965 
Integrating Najoud's feature
@rkensouh
Merge branch 'f24' into reem-feature
c9f99d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.