Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored file src/index/search.js to avoid nesting #12

Open
wants to merge 2 commits into
base: f24
Choose a base branch
from

Conversation

mrahmatu
Copy link

@mrahmatu mrahmatu commented Aug 29, 2024

This pull request simplifies the code by directly joining all translations into a single string and improving the way titles are created from the namespace. I replaced the complex nested template literals with straightforward steps, using simple if statements to handle different parts of the title. These changes make the code cleaner, easier to read, and less prone to errors.

Copy link

@mrahmatu mrahmatu changed the title changed lines 100-107 to avoid nesting Refactored file src/index/search.js to avoid nesting Aug 29, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10614744225

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 82.665%

Totals Coverage Status
Change from base Build 10555752308: -0.001%
Covered Lines: 22324
Relevant Lines: 25584

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants