Converted src/languages.js from JS to TS #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This only has one commit as I reinstalled NobeBB and inserted my code. My file runs on my local computer (as I showed the Professor) but it does not pass the git hub tests. I can't try and fix the errors locally when I can not see the errors and I don't have access to re-run the tests on Github. I have worked really hard translating this file as I do not know Typescript or Javascript and I am sure my translation is right as I ran it locally with no errors and high coverage. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #43
I updated the type declarations for all variables, functions, and objects to ensure they are no longer of type 'any.' To validate the correctness of the TypeScript file, I executed 'npm run lint' and 'npm run test' tests.