Custom errors and Gas optimizations (#1) #216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* For loops and function arguments optimization * Substitute require statements with custom errors
…idity version to 0.8.20, update code and test for MetaTxModule, replace _beforeTokenTransfer by _update
|
Replaced by #217 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This task is made of these following subtasks:
-- [x] Substitute require statements with custom errors inside the solidity code
-- [x] Update the OpenZeppelin version to the latest commit
--- [x] The internal function from OpenZeppelin
_beforeTokenTransferis replaced by_update--- [x] The forwarder from OpenZeppelin used in mock have also several improvements, requiring to update the tests.
-- [ ] Update the tests to check the custom errors
Closes #188 , #133
Closes #131, #61