Skip to content

Commit

Permalink
[QPPA-458][Bug Fix] Include benchmarks that were excluded during conv…
Browse files Browse the repository at this point in the history
…ersion (#92)

Ticket: https://jira.cms.gov/browse/QPPA-458
Reviewer: @marimiyachi
  • Loading branch information
lamroger authored Nov 16, 2017
1 parent a8ded32 commit 152ae2f
Show file tree
Hide file tree
Showing 10 changed files with 2,633 additions and 17 deletions.
1 change: 1 addition & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ Similarly, `util/benchmarks/additional-benchmarks-2017.json` contains benchmark
### Additional benchmarks

To add or update benchmarks, you'll want to convert the csv file into JSON with the `scripts/benchmarks/parse-benchmarks-data.js`. `parse-benchmarks-data.js` relies on a set of columns to be present and additional empty columns can cause the parsing to fail. See that file for additional instructions on how to generate the JSON file.
Also, `parse-benchmarks-data.js` cross references for measureIds in `measures/measures-data.json` for the correct usage. If none are matched, either a padded `000` digit will be used for `measureId`s with all digits or a non-spaced version of the `measureId` will be used.

After you have the parsed JSON file, move the CSV and JSON into `staging/benchmarks/csv` and `staging/benchmarks/json`. We do this for auditing and regeneration purposes. You'll notice a number prepended to both files. We number each file to enforce ordering of merges. Currently, if two benchmarks have the same Measure ID, Benchmark Year, Performance Year, and Submission method, the one that exists in the larger numbered file will overwrite the smaller one.

Expand Down
Loading

0 comments on commit 152ae2f

Please sign in to comment.