refactor: remove redundant check

CMSgov · Jul 25, 2023 · 832a85a · 832a85a
1 parent f0e6944
commit 832a85a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 20 deletions.
diff --git a/src/csv.ts b/src/csv.ts
@@ -361,14 +361,6 @@ export function validateColumns(columns: string[]): CsvValidationError[] {
 export function validateWideColumns(columns: string[]): CsvValidationError[] {
   const rowIndex = 2
   const errors: CsvValidationError[] = []
-  const wideColumns = getWideColumns(columns)
-
-  // TODO: incorporate order later on?
-  wideColumns.forEach((column) => {
-    if (!columns.some((c) => sepColumnsEqual(column, c))) {
-      errors.push(csvErr(rowIndex, 0, column, `Missing column "${column}"`))
-    }
-  })
 
   if (columns[columns.length - 1] !== "additional_generic_notes") {
     errors.push(

diff --git a/test/csv.spec.ts b/test/csv.spec.ts
@@ -98,24 +98,16 @@ test("validateColumns tall", (t) => {
 })
 
 test("validateWideColumns", (t) => {
+  // Currently only checking for the order of additional_generic_notes
   t.is(
     validateWideColumns([
       ...BASE_COLUMNS,
       ...MIN_MAX_COLUMNS,
-      "standard_charge |Payer | Plan",
-      "additional_generic_notes",
-    ])[0].message,
-    `Missing column "standard_charge | Payer | Plan | percent"`
-  )
-  t.is(
-    validateWideColumns([
-      ...BASE_COLUMNS,
-      ...MIN_MAX_COLUMNS,
-      "standard_charge |Payer | Plan",
-      "standard_charge | Payer |Plan | pct",
+      "standard_charge | Payer | Plan",
       "additional_generic_notes",
+      "standard_charge | Payer | Plan | pct",
     ]).length,
-    3
+    1
   )
 })