DPC-4468 Full deploy via Github Actions #2438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/DPC-4468
🛠 Changes
ℹ️ Context
We are migrating from Jenkins to Github Actions. This new workflow encompasses
The java containers 'retry' logic was enhanced because
make ci-appwas failing in the build stage, and debugging implied that it just needed more time. The builds stopped failing with the increase.Not cleaning up docker in the _finally method in dpc-test.sh allows us to debug on failure (otherwise the containers are deleted, and we can't see the logs).
🧪 Validation
Successful build and release.