Me/dpc 4501 remove get total #2436
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MEspositoE14s
commented
Feb 11, 2025
| @@ -1,5 +1,3 @@ | |||
| version: '3' | |||
There was a problem hiding this comment.
Not really necessary, but I was getting a warning that this was deprecated while rebuilding so I got rid of it.
chris-ronning-ny
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/DPC-4501
🛠 Changes
Bundle.getTotal()to determine if calls to BFD were successful.totalelement from our test bundles.ℹ️ Context
The
totalelement isn't required in a bundle, so we shouldn't be relying on it, and the BFD team is considering a change that will remove it in the future so this makes sure we won't have any issues if they do.Note: The large number of deleted test files were from DPC v2, which was removed a long time ago.
🧪 Validation
Removed total from all test data and made sure tests pass locally.