Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPC-4472 fix workflow names #2393

Merged
merged 4 commits into from
Jan 24, 2025
Merged

DPC-4472 fix workflow names #2393

merged 4 commits into from
Jan 24, 2025

Conversation

jdettmannnava
Copy link
Contributor

🎫 Ticket

https://jira.cms.gov/browse/DPC-4472

🛠 Changes

Top-level names changed for multiple workflows.

ℹ️ Context

I had left 'dev' in some workflow names, and thought standardizing naming would be useful.

🧪 Validation

After merge, will verify names in Actions look better.

Copy link
Contributor

@chris-ronning-ny chris-ronning-ny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So to check my understanding: top-level workflows take the pattern [Dpc-Service-Name Action Being Taken], and workflows that are composed into others as utilities get the pattern [utility-action-being-taken].

Is that understanding correct?

@jdettmannnava
Copy link
Contributor Author

@chris-ronning-ny : Yes! This way services are grouped together (so api-waf-sync deploy and integration tests are together) and the utilities are down at the bottom and out of the way.

@jdettmannnava jdettmannnava merged commit 918aaaf into main Jan 24, 2025
21 checks passed
@jdettmannnava jdettmannnava deleted the jd/dpc-4472-fix-names branch January 24, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants