Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPC-4472 dedupe workflows #2391

Merged
merged 18 commits into from
Jan 23, 2025
Merged

DPC-4472 dedupe workflows #2391

merged 18 commits into from
Jan 23, 2025

Conversation

jdettmannnava
Copy link
Contributor

@jdettmannnava jdettmannnava commented Jan 21, 2025

🎫 Ticket

https://jira.cms.gov/browse/DPC-4472

🛠 Changes

  • logic for deploying api-waf-sync, opt-out-import, opt-out-export consolidated to deploy_go.yml
  • workflows differentiated by environment consolidated into single workflows with environment variable

ℹ️ Context

Rampant duplication of code consolidated for ease of maintenance and for running workflows.

🧪 Validation

Deploy workflows ran automatically and passed tests (see checks).

@jdettmannnava jdettmannnava changed the title Jd/dpc 4472 dedupe workflows DPC-4472 dedupe workflows Jan 22, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: are the underscores in the file name intentional vs the hyphens in all the other yml files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! I have been using dashes for workflows we run and underscores for reusable workflows

Copy link
Contributor

@ashley-weaver ashley-weaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdettmannnava jdettmannnava merged commit c4e539f into main Jan 23, 2025
20 checks passed
@jdettmannnava jdettmannnava deleted the jd/dpc-4472-dedupe-workflows branch January 23, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants