-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DPC-4472 dedupe workflows #2391
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: are the underscores in the file name intentional vs the hyphens in all the other yml files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup! I have been using dashes for workflows we run and underscores for reusable workflows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎫 Ticket
https://jira.cms.gov/browse/DPC-4472
🛠 Changes
ℹ️ Context
Rampant duplication of code consolidated for ease of maintenance and for running workflows.
🧪 Validation
Deploy workflows ran automatically and passed tests (see checks).