Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing switches, alphabetize switches, support notes for switches. #1295

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jimmyfagan
Copy link
Contributor

JIRA Ticket:
BB2-3346

What Does This PR Do?

This PR adds some waffle switches to our local environment, so that testing locally more closely mimics the behavior we would see in TEST/SBX/PROD. While editing these switches, I also added support for notes to be included in the automatically locally created switches, and put them in alphabetical order.

What Should Reviewers Watch For?

If you're reviewing this PR, please check for these things in particular:

  • Are any of these switches ones that we should omit from local envs for some reason?

Validation

Navigate to http://localhost:8000/admin/waffle/switch in your local environment, and compare to the same page in the other environments.
Confirm that http://localhost:8000/home shows the Spanish language feature message. Optionally, disable show_django_message_sdk and see that the message goes away.

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies
  • Modifies any security controls
  • Adds new transmission or storage of data
  • Any other changes that could possibly affect security?
  • Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team
    security engineer's approval.

Any Migrations?

  • Yes, there are migrations
    • The migrations should be run PRIOR to the code being deployed
    • The migrations should be run AFTER the code is deployed
    • There is a more complicated migration plan (downtime,
      etc)
  • No migrations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant