Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jimfuqian/BB2-3311 Remove selenium tests webdriver opt setting window-size #1248

Conversation

JFU-NAVA-PBC
Copy link
Contributor

@JFU-NAVA-PBC JFU-NAVA-PBC commented Sep 17, 2024

JIRA Ticket:
BB2-3311

What Does This PR Do?

Remove Selenium Chrome webdriver opt setting: window-size
this results in the selenium tests VNC web UI rendering takes the default viewport setting which is preferred - page content centered and proportioned in the VNC view, better for tests user interaction checking and trouble shooting.

What Should Reviewers Watch For?

If you're reviewing this PR, please check for these things in particular:

Validation

Check out the PR to local and run a selenium tests remote or local
Start VNC viewer and observe the web UI interaction in VNC viewer
Expected: the web UI should be centered

VNC viewer setup:

Below screen shot is the VNC viewer setup (any vnc viewer will do, here realVNC used as example):

image

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies
  • Modifies any security controls
  • Adds new transmission or storage of data
  • Any other changes that could possibly affect security?
  • Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team
    security engineer's approval.

Any Migrations?

  • Yes, there are migrations
    • The migrations should be run PRIOR to the code being deployed
    • The migrations should be run AFTER the code is deployed
    • There is a more complicated migration plan (downtime,
      etc)
  • No migrations

@JFU-NAVA-PBC JFU-NAVA-PBC requested a review from a team September 17, 2024 15:15
Copy link
Contributor

@jimmyfagan jimmyfagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

…selenium-tests-remove-webdriver-set-window-size
Copy link
Contributor

@noor1027 noor1027 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…selenium-tests-remove-webdriver-set-window-size
@JFU-NAVA-PBC JFU-NAVA-PBC merged commit 5a79028 into master Sep 23, 2024
6 checks passed
@JFU-NAVA-PBC JFU-NAVA-PBC deleted the jimfuqian/BB2-3311-selenium-tests-remove-webdriver-set-window-size branch September 23, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants