Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BFD-3332: Complete yum transactions explicitly #2247

Merged
merged 1 commit into from
Mar 18, 2024
Merged

BFD-3332: Complete yum transactions explicitly #2247

merged 1 commit into from
Mar 18, 2024

Conversation

mjburling
Copy link
Member

@mjburling mjburling commented Mar 15, 2024

JIRA Ticket:
BFD-3332

User Story or Bug Summary:
Improve reliability of existing packer image creation process with explicit calls to yum-complete-transaction.


What Does This PR Do?

It's unclear exactly what is responsible for the current issues, but something appears to be interrupting the yum package manager. The misbehaving process yields intermittent errors, which has made the root cause identification difficult. It's also unclear if this has been resolved by the application of yum-complete-transaction or if any ansible task that introduces a few extra seconds at the tail end of the ansible provisioner in packer would be enough to avoid the interruptions. Regardless, this is a fairly light-weight change which has made for more reliable image creation.

This introduces a common, trivial dependency in yum-utils which includes the yum-complete-transaction scripting. Out of an abundance of caution, I've requested that @StewGoin weigh-in on the inclusion of yum-utils before accepting this into the trunk.

What Should Reviewers Watch For?

If you're reviewing this PR, please check for these things in particular:

  • Verify all PR security questions and checklists have been completed and addressed.

What Security Implications Does This PR Have?

Submitters should complete the following questionnaire:

  • If the answer to any of the questions below is Yes, then you must supply a link to the associated Security Impact Assessment (SIA), security checklist, or other similar document in Confluence here:

    • Does this PR add any new software dependencies?
      • Yes
      • No
    • Does this PR modify or invalidate any of our security controls?
      • Yes
      • No
    • Does this PR store or transmit data that was not stored or transmitted before?
      • Yes
      • No
  • If the answer to any of the questions below is Yes, then please add @StewGoin as a reviewer, and note that this PR should not be merged unless/until he also approves it.

    • Do you think this PR requires additional review of its security implications for other reasons?
      • Yes
      • No

What Needs to Be Merged and Deployed Before this PR?

This PR cannot be either merged or deployed until the following prerequisite changes have been fully deployed:

  • N/A

Submitter Checklist

I have gone through and verified that...:

  • I have named this PR and branch so they are automatically linked to the (most) relevant Jira issue. Ie: BFD-123: Adds foo
  • This PR is reasonably limited in scope, to help ensure that:
    1. It doesn't unnecessarily tie a bunch of disparate features, fixes, refactorings, etc. together.
    2. There isn't too much of a burden on reviewers.
    3. Any problems it causes have a small "blast radius".
    4. It'll be easier to rollback if that becomes necessary.
  • This PR includes any required documentation changes, including README updates and changelog / release notes entries.
  • The data dictionary has been updated with any field mapping changes, if any were made.
  • All new and modified code is appropriately commented, such that the what and why of its design would be reasonably clear to engineers, preferably ones unfamiliar with the project.
  • All tech debt and/or shortcomings introduced by this PR are detailed in TODO and/or FIXME comments, which include a JIRA ticket ID for any items that require urgent attention.
  • Reviews are requested from both:
    • At least two other engineers on this project, at least one of whom is a senior engineer or owns the relevant component(s) here.
    • Any relevant engineers on other projects (e.g. DC GEO, BB2, etc.).
  • Any deviations from the other policies in the DASG Engineering Standards are specifically called out in this PR, above.
    • Please review the standards every few months to ensure you're familiar with them.

@mjburling mjburling requested a review from StewGoin March 15, 2024 00:16
Copy link

@StewGoin StewGoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to proceed, we should consider marking this as some known debt/defect to OBE with shifting off AL 2 if we can soon-ish.

@mjburling mjburling merged commit 6416b8a into master Mar 18, 2024
9 checks passed
@mjburling mjburling deleted the bfd-3332 branch March 18, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants