BFD-3332: Complete yum transactions explicitly #2247
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BFD-3332
User Story or Bug Summary:
Improve reliability of existing packer image creation process with explicit calls to
yum-complete-transaction
.What Does This PR Do?
It's unclear exactly what is responsible for the current issues, but something appears to be interrupting the yum package manager. The misbehaving process yields intermittent errors, which has made the root cause identification difficult. It's also unclear if this has been resolved by the application of
yum-complete-transaction
or if any ansible task that introduces a few extra seconds at the tail end of the ansible provisioner in packer would be enough to avoid the interruptions. Regardless, this is a fairly light-weight change which has made for more reliable image creation.This introduces a common, trivial dependency in
yum-utils
which includes theyum-complete-transaction
scripting. Out of an abundance of caution, I've requested that @StewGoin weigh-in on the inclusion ofyum-utils
before accepting this into the trunk.What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
What Security Implications Does This PR Have?
Submitters should complete the following questionnaire:
If the answer to any of the questions below is Yes, then you must supply a link to the associated Security Impact Assessment (SIA), security checklist, or other similar document in Confluence here:
If the answer to any of the questions below is Yes, then please add @StewGoin as a reviewer, and note that this PR should not be merged unless/until he also approves it.
What Needs to Be Merged and Deployed Before this PR?
This PR cannot be either merged or deployed until the following prerequisite changes have been fully deployed:
Submitter Checklist
I have gone through and verified that...:
BFD-123: Adds foo
README
updates and changelog / release notes entries.TODO
and/orFIXME
comments, which include a JIRA ticket ID for any items that require urgent attention.