Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCDA-5938: Decrease code complexity for function getNewAndExistingBeneficiaries #803

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

4ell0
Copy link
Contributor

@4ell0 4ell0 commented Oct 25, 2022

Fixes BCDA-5938

Decrease code complexity for function getNewAndExistingBeneficiaries and its tests

  • move logic in getNewAndExistingBeneficiaries into smaller functions
  • update tests

Security Implications

  • new software dependencies
  • security controls or supporting software altered
  • new data stored or transmitted
  • security checklist is completed for this change
  • requires more information or team discussion to evaluate security implications
  • no PHI/PII is affected by this change

Acceptance Validation

Feedback Requested

@codecov-commenter
Copy link

Codecov Report

Merging #803 (c8e96d0) into master (271467d) will decrease coverage by 0.02%.
The diff coverage is 75.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #803      +/-   ##
==========================================
- Coverage   75.04%   75.01%   -0.03%     
==========================================
  Files          89       89              
  Lines       10234    10259      +25     
==========================================
+ Hits         7680     7696      +16     
- Misses       1950     1956       +6     
- Partials      604      607       +3     
Impacted Files Coverage Δ
bcda/service/service.go 83.05% <75.86%> (+0.31%) ⬆️
bcda/models/fhir/alr/v2/group.go 87.79% <0.00%> (-1.75%) ⬇️
bcda/models/fhir/alr/v1/group.go 88.00% <0.00%> (-1.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 271467d...c8e96d0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants