pg/Serial: pass std::string_view to Parse()

src/pg/Serial.cxx

@@ -3,32 +3,30 @@
 // author: Max Kellermann <[email protected]>
 
 #include "Serial.hxx"
+#include "util/NumberParser.hxx"
 
 #include <stdexcept>
-#include <cstdlib>
 
 namespace Pg {
 
 Serial
-Serial::Parse(const char *s)
+Serial::Parse(std::string_view s)
 {
-	char *endptr;
-	auto value = std::strtoul(s, &endptr, 10);
-	if (endptr == s || *endptr != 0)
+	const auto value = ParseInteger<value_type>(s);
+	if (!value)
 		throw std::invalid_argument("Failed to parse serial");
 
-	return Serial(value);
+	return Serial{*value};
 }
 
 BigSerial
-BigSerial::Parse(const char *s)
+BigSerial::Parse(std::string_view s)
 {
-	char *endptr;
-	auto value = std::strtoul(s, &endptr, 10);
-	if (endptr == s || *endptr != 0)
+	const auto value = ParseInteger<value_type>(s);
+	if (!value)
 		throw std::invalid_argument("Failed to parse serial");
 
-	return BigSerial{value};
+	return BigSerial{*value};
 }
 
 }

src/pg/Serial.hxx

@@ -5,6 +5,7 @@
 #pragma once
 
 #include <cstdint>
+#include <string_view>
 
 namespace Pg {
 
@@ -32,7 +33,7 @@ public:
 	 * std::invalid_argument on error.
 	 */
 	[[nodiscard]]
-	static Serial Parse(const char *s);
+	static Serial Parse(std::string_view s);
 };
 
 /**
@@ -59,7 +60,7 @@ public:
 	 * std::invalid_argument on error.
 	 */
 	[[nodiscard]]
-	static BigSerial Parse(const char *s);
+	static BigSerial Parse(std::string_view s);
 };
 
 }