Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to check names of variables, functions,... #56

Open
noonbluemoon opened this issue Sep 19, 2016 · 2 comments · May be fixed by #159
Open

Ability to check names of variables, functions,... #56

noonbluemoon opened this issue Sep 19, 2016 · 2 comments · May be fixed by #159
Labels
enhancement

Comments

@noonbluemoon
Copy link

Hey,

thanks a lot for your great spell checker! It works awesome for strings and comments.
However, we often face the problem to also have typos / misspellings in the source code itself, i.e. variables, functions, classes, etc.. For instance, the typos in the variable m_defoultLeftMergin should be detected and changable to m_defaultLeftMargin by using the CamelCaseSplitCorrection.
We would love to have another option to the settings to not only check strings and/or comments but also the actual source code?

How complicated would it be to realize this? Is there any chance that this feature will come soon?

Thanks a lot!
Ines
@noonbluemoon noonbluemoon changed the title Enable to check names of variables, functions,... Ability to check names of variables, functions,... Sep 19, 2016
@CJCombrink
Copy link
Owner

Hi,

I am glad the spellchecked is working for you.

Regarding your request, I do not see that this will be a big issue to do. The spell checker already extract variables and functions from the files during parsing to remove 'false positives' of comments that refers to variables with not-normal spelling. I will just have to see what the implications will be if one now try to also pass that through the spell checking logic.

The bad news is that since my development laptop stopped working it is very difficult to work on the spell checker. I have a setup to build and test, but development is a bit painful with this setup. It is something I will look into when I get my setup going again, but it might only be in about a month or so.

Regard,

@noonbluemoon
Copy link
Author

Hey,

thanks for your fast reply!

We would really appreciate to have this feature! We develop following the CleanCode principle (https://www.amazon.com/Clean-Code-Handbook-Software-Craftsmanship/dp/0132350882). Thus, having a spellchecker for variable/function/... names is much more important to us than to spellcheck comments because we only comment where it is really necessary (apart from documentation).

So, we are looking forward to have your development setup working again :-).

Best regards,
Ines

@CJCombrink CJCombrink mentioned this issue Jun 21, 2018
Closed
@zeule zeule linked a pull request Jun 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add checks for identifiers zeule/qtc-SpellChecker-Plugin
2 participants
@CJCombrink @noonbluemoon