-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore cycles #294
Ignore cycles #294
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
for ignoring cycles we need latest version of networkx
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #294 +/- ##
==========================================
+ Coverage 96.97% 97.01% +0.04%
==========================================
Files 29 29
Lines 1816 1842 +26
==========================================
+ Hits 1761 1787 +26
Misses 55 55
Continue to review full report in Codecov by Sentry.
|
@jmafoster1 Looks like there are also some codecov patches that are failing, could you have a look at them when you have time? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmafoster1 LGTM
Added an
--ignore_cycles
option tomain_dafni.py
to bypass the DAG validity check for the EA case study