Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore cycles #294

Merged
merged 14 commits into from
Dec 3, 2024
Merged

Ignore cycles #294

merged 14 commits into from
Dec 3, 2024

Conversation

jmafoster1
Copy link
Contributor

Added an --ignore_cycles option to main_dafni.py to bypass the DAG validity check for the EA case study

Copy link

github-actions bot commented Nov 15, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 36 0 1.02s
✅ PYTHON pylint 36 0 5.99s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@jmafoster1 jmafoster1 marked this pull request as draft November 25, 2024 14:42
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.01%. Comparing base (e6d46cd) to head (499fc54).
Report is 16 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #294      +/-   ##
==========================================
+ Coverage   96.97%   97.01%   +0.04%     
==========================================
  Files          29       29              
  Lines        1816     1842      +26     
==========================================
+ Hits         1761     1787      +26     
  Misses         55       55              
Files with missing lines Coverage Δ
causal_testing/json_front/json_class.py 98.00% <100.00%> (ø)
causal_testing/specification/causal_dag.py 98.95% <100.00%> (+0.05%) ⬆️
...usal_testing/specification/metamorphic_relation.py 98.43% <100.00%> (+0.23%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de0a676...499fc54. Read the comment docs.

causal_testing/specification/causal_dag.py Outdated Show resolved Hide resolved
causal_testing/specification/causal_dag.py Outdated Show resolved Hide resolved
causal_testing/specification/causal_dag.py Outdated Show resolved Hide resolved
@jmafoster1 jmafoster1 marked this pull request as ready for review November 29, 2024 10:04
@f-allian
Copy link
Contributor

@jmafoster1 Looks like there are also some codecov patches that are failing, could you have a look at them when you have time?

@jmafoster1 jmafoster1 requested a review from f-allian November 29, 2024 16:28
Copy link
Contributor

@f-allian f-allian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmafoster1 jmafoster1 merged commit 4fdf12b into main Dec 3, 2024
13 checks passed
@jmafoster1 jmafoster1 deleted the ignore-cycles branch December 3, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants