Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out draft PRs from normal ci workflow #256

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

christopher-wild
Copy link
Contributor

This duplicate ci workflow is required so the badge in the README.md is not effected by draft PRs

Copy link

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 26 0 0.86s
✅ PYTHON pylint 26 0 4.21s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e801243) 95.32% compared to head (ed0b97a) 95.32%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #256   +/-   ##
=======================================
  Coverage   95.32%   95.32%           
=======================================
  Files          20       20           
  Lines        1411     1411           
=======================================
  Hits         1345     1345           
  Misses         66       66           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebb3339...ed0b97a. Read the comment docs.

Copy link
Contributor

@f-allian f-allian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for looking into this @cwild-UoS

@f-allian f-allian merged commit b82241f into main Jan 16, 2024
7 checks passed
@christopher-wild christopher-wild deleted the ignore-draft-badge branch January 16, 2024 16:43
@f-allian f-allian restored the ignore-draft-badge branch January 24, 2024 16:24
@christopher-wild christopher-wild deleted the ignore-draft-badge branch April 4, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants