fix netcdf s3 write

forcingprocessor/src/forcingprocessor/processor.py

@@ -583,9 +583,9 @@ def write_netcdf(data, vpu, t_ax, catchments):
     import netCDF4 as nc
 
     if storage_type == 's3':
-        bucket, key = convert_url2key(nc_filename,s3_client)
+        bucket, key = convert_url2key(nc_filename,'s3')
         with tempfile.NamedTemporaryFile(suffix='.nc') as tmpfile:
-            with nc.Dataset(tmpfile, 'w', format='NETCDF4') as ds:
+            with nc.Dataset(tmpfile.name, 'w', format='NETCDF4') as ds:
                 catchment_dim = ds.createDimension('catchment-id', len(catchments))
                 time_dim = ds.createDimension('time', len(t_utc))
                 ids_var = ds.createVariable('ids', str, ('catchment-id',))
@@ -610,8 +610,11 @@ def write_netcdf(data, vpu, t_ax, catchments):
                 spfh_var[:, :] = data[:, 6, :]
                 pres_var[:, :] = data[:, 7, :]
                 dswrf_var[:, :] = data[:, 8, :]
-                tmpfile.seek(0)
-                s3_client.upload_file(tmpfile.name, bucket, key)
+            tmpfile.flush()
+            tmpfile.seek(0)
+            print(f"Uploading netcdf forcings to S3: bucket={bucket}, key={key}")
+            s3_client.upload_file(tmpfile.name, bucket, key)
+            os.system('rm -rf ./<tempfile*')
     else:
         with nc.Dataset(nc_filename, 'w', format='NETCDF4') as ds:
             catchment_dim = ds.createDimension('catchment-id', len(catchments))