New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure outputs for 1D RM synthesis are actually the dType that user requested #150

Merged

Cameron-Van-Eck merged 2 commits into master from dev

Dec 5, 2024

Contributor

ErikOsinga commented Nov 28, 2024 •

edited

Loading

Fixes the bug that whatever nBits was when the user called do_RMsynth_1D.run_rmsynth() the output would be returned as:

FDF as complex128
RMSF as complex128
phi_fdf as float<nBits> (this was the only thing correctly assigned)
phi_rmsf as float64

Now the outputs will be forced to:

    aDict["phiArr_radm2"] = phiArr_radm2.astype(dtFloat)
    aDict["phi2Arr_radm2"] = phi2Arr_radm2.astype(dtFloat)
    aDict["RMSFArr"] = RMSFArr.astype(dtComplex)
    aDict["freqArr_Hz"] = freqArr_Hz.astype(dtFloat)
    aDict["weightArr"] = weightArr.astype(dtFloat)
    aDict["dirtyFDF"] = dirtyFDF.astype(dtComplex)

ErikOsinga and others added 2 commits

November 28, 2024 10:15


          Make sure outputs are actually the dType that user requested

f1c6a22


          [pre-commit.ci] auto fixes from pre-commit.com hooks

d16da20

for more information, see https://pre-commit.ci

ErikOsinga requested review from AlecThomson and Cameron-Van-Eck

November 28, 2024 15:20

Contributor Author

ErikOsinga commented Nov 28, 2024

FYI: I also commented out some variables that were being set/calculated but not actually being used.

Cameron-Van-Eck merged commit 000139a into master

13 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet