Fix imodelrescale, issue #142 #143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…into RMpeakfit_headers
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
… function for trimming headers, but its not working
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
Argh, another branch issue, I thought this would only have the last commit 2709ffc ... my bad.. |
|
The fix looks good to me, but this PR has all the other commits/changes attached, so it's going to make a bit of a mess of things when I try to merge everything in. Is it possible to start over with a PR that only has the changes for this issue (I'm not sure if it can be changed without deleting this PR and making a new one)? This is kind of on me for not keeping up on merging in PRs. I'll put it on my to-do list for sometime in the next few weeks to go through and merge in everything that's ready. |
|
See #144 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #142