Cubenoisenan #140
Closed
Cubenoisenan #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I seem to be not so good with multiple branching yet.. now this branch also includes the commit for #139 .... |
|
Also already merged into dev, so I'm closing the PR (sorry, you're probably getting a bunch of spam in a row from all of these) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
cube_noiseis quite slow, and a lot slower than it needs to be for datasets that have planes/channels fully flagged.This small improvement now checks whether the plane is fully flagged and if so, sets the
noiseandskymediantonp.nanright away instead of doing a bunch of useless NaN calculations.This will be particularly important for non-uniform frequency coverage if the users implementation is "simply add NaN channels to make the frequency coverage uniform"