Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RMSF and add return vals #129

Merged
merged 6 commits into from
May 8, 2024
Merged

Fix RMSF and add return vals #129

merged 6 commits into from
May 8, 2024

Conversation

AlecThomson
Copy link
Contributor

Closes #128

@AlecThomson AlecThomson added the bug Something isn't working label May 6, 2024
@AlecThomson
Copy link
Contributor Author

Python 3.8 tests seem to be failing on Bilby issues for some reason. But otherwise I think this is looking ok

@AlecThomson
Copy link
Contributor Author

Interesting, numpy-1.22.3 and bilby-2.2.2 seem to be incompatible on the Python 3.8 tests. Bumping the numpy version up in the tests seemed to do the trick. I'll try to put this in the setup.py to avoid the issue for users

@AlecThomson
Copy link
Contributor Author

@Cameron-Van-Eck when you get a chance to squiz, I think this is g2g

Copy link
Collaborator

@Cameron-Van-Eck Cameron-Van-Eck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like I haven't entirely been sold on these NamedTuples, but I can't deny that they solve the problem in this case. I should really spend some time getting comfortable with them...

@Cameron-Van-Eck Cameron-Van-Eck merged commit 314c476 into master May 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RMSF helper script is bugged
2 participants