Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 5 new models. #118

Closed
wants to merge 18 commits into from
Closed

Added 5 new models. #118

wants to merge 18 commits into from

Conversation

loberhelman
Copy link
Contributor

M8 model is a Uniform slab with a linear foreground screen in front of it.
M9 model is a random slab with a linear foreground screen in front of it.

leoberhelman and others added 12 commits March 17, 2024 14:11
@leoberhelman
Added two new models
4deaec9
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
38214b8 
for more information, see https://pre-commit.ci
@loberhelman
Merge branch 'CIRADA-Tools:master' into master
0ec914d
@leoberhelman
Updated 9 and 8 and added another mixed slab model
f03fff8
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
5ffb432 
for more information, see https://pre-commit.ci
@leoberhelman
add a uniform slab model 5 has a FR screen in front of it
3996bff
@leoberhelman
fixed slab
d5a95d2
@leoberhelman
Merge branch 'master' of https://github.com/loberhelman/RM-Tools
505386c
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
add2dfe 
for more information, see https://pre-commit.ci
@leoberhelman
Made a uniform emission screen model
624c020
@leoberhelman
Merge branch 'master' of https://github.com/loberhelman/RM-Tools
955a39d
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
f2597e4 
for more information, see https://pre-commit.ci
@loberhelman loberhelman changed the title Added two new models. Added 5 new models. Apr 11, 2024
@loberhelman
Copy link
Contributor Author

Added a Uniform Emission Screen
Added a Uniform Slab model m5 has a FR screen in front
Added another random slab model

Cameron-Van-Eck
Cameron-Van-Eck requested changes Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@Cameron-Van-Eck Cameron-Van-Eck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed elsewhere:

  • Let's ditch the m1a model as uninteresting.
  • Ditto m5a.
  • 9a.py should be m9a.py, for consistency.
  • Confirm that models with a in the name run as expected.

@Cameron-Van-Eck
Copy link
Collaborator

Closing at Lindsey's request -- outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cameron-Van-Eck Cameron-Van-Eck Cameron-Van-Eck requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loberhelman @Cameron-Van-Eck @leoberhelman