Fixed bug in 3D RMSF calculation with non-uniform channels -- introdu…

…ced by switch to nufft.
CIRADA-Tools · May 28, 2024 · 3b22726 · 3b22726
1 parent f935c42
commit 3b22726
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/RMutils/util_RM.py b/RMutils/util_RM.py
@@ -405,7 +405,7 @@ def get_rmsf_planes(
             finufft.nufft1d3(
                 x=a,
                 c=np.ascontiguousarray(weightCube.T),
-                s=(phiArr_radm2[::-1] * 2).astype(a.dtype),
+                s=(phi2Arr[::-1] * 2).astype(a.dtype),
                 eps=eps,
             )
             * KArr[..., None]

diff --git a/VERSION_HISTORY.txt b/VERSION_HISTORY.txt
@@ -1,4 +1,7 @@
 
+1.4.6:
+-fixed bug in rmsynth3d when computing RMSF that is not spatially uniform.
+
 1.4.5:
 -Fixed 3DIrescale tool to work with new NamedTuple for Stokes I fitting outputs.
 

diff --git a/setup.py b/setup.py
@@ -10,7 +10,7 @@
 DESCRIPTION = "RM-synthesis, RM-clean and QU-fitting on polarised radio spectra"
 URL = "https://github.com/CIRADA-Tools/RM-Tools"
 REQUIRES_PYTHON = ">=3.7.0"
-VERSION = "1.4.5"
+VERSION = "1.4.6"
 DOWNLOAD_URL = (
     "https://github.com/CIRADA-Tools/RM-Tools/archive/v" + VERSION + ".tar.gz"
 )