Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency to third_robot_navigation_gazebo #12

Merged
merged 7 commits into from
Nov 17, 2016

Conversation

MoriKen254
Copy link
Member

#11 の対応の一環で,third_robot_navigation_gazebo への依存関係を解消しました.

third_robot_gazebo への依存が残っていますが,それの対応は別途Pull-requestを出すこととします.

READMEの

roslaunch cirkit_unit03_navigation_gazebo gmapping.launch

はまだ置かれていません.今後対応予定ということで,変更してありますのでご了承下さい.

@forno
Copy link
Contributor

forno commented Nov 17, 2016

third_robot_gazebo 以外のthird と名の付くパッケージ呼び出しがあるようです。
third_robot_merge_laserlaunch/autorun_with_human.launch, launch autorun.launchから呼び出されています。

cirkit_unit03/cirkit_unit03_navigation_gazebo$ grep -r third | grep -v third_robot_gazebo
launch/autorun_with_human.launch:    args="1 third_robot_merge_laser third_robot_laserscan_merger.launch"
launch/amcl_diff.launch:    <node pkg="topic_tools" type="relay" name="relay_base_scan" args="/third_robot/laser/base_scan /base_scan"/>
launch/amcl_diff.launch:    <node pkg="topic_tools" type="relay" name="relay_base_scan2" args="/third_robot/laser/base_scan2 /base_scan2"/>
launch/waypoint_generator.launch:    args="1 third_robot_merge_laser third_robot_laserscan_merger.launch"
launch/autorun.launch:    args="1 third_robot_merge_laser third_robot_laserscan_merger.launch"
config/artorun_gazebo_.rviz:      Topic: /third_robot/laser/base_scan
config/artorun_gazebo_.rviz:      Topic: /third_robot/laser/base_scan2

@MoriKen254
Copy link
Member Author

すみません,今 CIR-KIT-Unit03/cirkit_unit03_whole_issue#2 で決めかねているpkgなので,保留にしていたところです.格納場所が決まったら改めて対応しようと思います.

とりあえず, third_robot_navigation_gazebo だけを解消したものとなっています.

@forno
Copy link
Contributor

forno commented Nov 17, 2016

わかりました。回答ありがとうございます。

なんだかmerge_laserさんの名前を見たことがあるなと思っていたら、Issue上だったのですね。
ではApprove致します。

Copy link
Contributor

@forno forno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

目視確認 及び grepでの確認完了。

@MoriKen254 MoriKen254 merged commit 6e601c5 into master Nov 17, 2016
@MoriKen254 MoriKen254 deleted the mm/fix/dependency/third_robot branch November 17, 2016 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants